Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu-uefi-x86: new board for virtualized environment with serial console support, kernel boot messages #6307

Merged
merged 3 commits into from
Mar 6, 2024
Merged

qemu-uefi-x86: new board for virtualized environment with serial console support, kernel boot messages #6307

merged 3 commits into from
Mar 6, 2024

Conversation

davidandreoletti
Copy link
Contributor

@davidandreoletti davidandreoletti commented Feb 26, 2024 •
edited by jira bot
Loading

As of 2024 Feb, Github still not allow source branch renaming. Previous PR #6291 was auto closed by Github upon source branch renaming. This new PR supersedes it.

Description

Running "uefi-x86" board image on qemu-system-x86_64 --display none --serial stdio ... did not:

  • allow GRUB boot without GUI display
  • display early kernel boot messages on the serial console
  • display the console prompt on serial console

@rpardini suggested adding a new board:.
This PR adds support for this new board along with the missing features above.

Jira reference number: None

How Has This Been Tested?

  • Test A: Boot uefi-x86 board image on qemu-system-x86_64 --display none --serial stdio ...
    • Armbian Build.git: 24.5.0-trunk
    • Build configuration: 
      BUILD_MINIMAL=no 
BUILD_DESKTOP=no
BOARD=uefi-x86
    • ✅ Result: early kernel messages + boot messages/prompt displayed on vm's serial console
image
  • Test B: Boot uefi-x86 board image on qemu-system-x86_64 --display auto -vga virtio ...
    • Armbian Build.git: 24.5.0-trunk
    • Build configuration:
    BUILD_MINIMAL=no 
BUILD_DESKTOP=yes
# Xfce desktop
BOARD=uefi-x86
    • ✅ Result: early kernel messages on serial + boot message/prompt displayed on serial + prompt displayed on GUI

image

AR-2289

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... Framework Framework components labels Feb 26, 2024
@davidandreoletti davidandreoletti marked this pull request as draft February 26, 2024 09:02
@davidandreoletti davidandreoletti changed the title uefi-x86(64) / uefi-arm64 serial console support uefi-x86(64) serial console support Mar 1, 2024
@davidandreoletti davidandreoletti force-pushed the uefi-x86-serial-console-support branch 2 times, most recently from 9cce9e3 to 296b7b8 Compare March 1, 2024 16:39
@davidandreoletti davidandreoletti marked this pull request as ready for review March 1, 2024 16:40
@rpardini rpardini force-pushed the uefi-x86-serial-console-support branch from 296b7b8 to 8c9c6bf Compare March 3, 2024 10:08
@rpardini
Copy link
Member

rpardini commented Mar 3, 2024

Hey @davidandreoletti -- uefi-x86 is meant as a generic board for hardware we don't know much about, so having those changes might/will probably break stuff when running on physical hardware. We've the BOARD=qemu-uboot-x86 but that's for using u-boot under qemu; maybe you're willing to create a new qemu-grub-x86 which isolates these changes?

@davidandreoletti
Copy link
Contributor Author

davidandreoletti commented Mar 3, 2024 •
edited
Loading

maybe you're willing to create a new qemu-grub-x86 which isolates these changes?

Yes, certainly. However, before doing so, I would like to know what setting(s) in particular might be troublesome - I'll document it in the new "board" and/or discard it from the commit:

  • Linux UEFI + grub support on x86-64 hardware/virtualization platform + debian is very good.
  • GRUB related settings should fallback gracefully when unsupported.

@davidandreoletti davidandreoletti force-pushed the uefi-x86-serial-console-support branch 3 times, most recently from 9ae0aa4 to 27ec60a Compare March 5, 2024 15:34
@davidandreoletti
Copy link
Contributor Author

davidandreoletti commented Mar 5, 2024 •
edited
Loading

@rpardini New board added: qemu-uefi-x86 !

All config changes affecting uefi-x86 board directly / indirectly have moved to qemu-uefi-x86 :-)
That should ease your concern about breaking any existing behaviour with the uefi-x86 board.

@rpardini / @igorpecovnik PR can be reviewed again.

@davidandreoletti davidandreoletti force-pushed the uefi-x86-serial-console-support branch from 27ec60a to fe4bd43 Compare March 5, 2024 15:39
@davidandreoletti davidandreoletti changed the title uefi-x86(64) serial console support qemu-uefi-x86: new board for virtualized environment with serial console support, kernel boot messages Mar 5, 2024
@davidandreoletti davidandreoletti force-pushed the uefi-x86-serial-console-support branch from fe4bd43 to 26cd3ec Compare March 5, 2024 16:19
rpardini
rpardini approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@rpardini rpardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for isolating the changes. Let's merge

@igorpecovnik igorpecovnik merged commit d1ee687 into armbian:main Mar 6, 2024
@igorpecovnik
Copy link
Member

@davidandreoletti how time flies :(
davidandreoletti/cubietruck@e3ed655

@davidandreoletti
Copy link
Contributor Author

davidandreoletti commented Mar 6, 2024 •
edited
Loading

@davidandreoletti how time flies :( davidandreoletti/cubietruck@e3ed655

@igorpecovnik Yep!

Congrats to you (and others) on making Armbian a viable OS for SBC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpardini rpardini rpardini approved these changes

@igorpecovnik igorpecovnik Awaiting requested review from igorpecovnik igorpecovnik is a code owner

Assignees
No one assigned
Labels
Framework Framework components Hardware Hardware related like kernel, U-Boot, ... size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidandreoletti @rpardini @igorpecovnik